[
https://issues.apache.org/jira/browse/PROTON-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361854#comment-17361854
]
Ken Giusti commented on PROTON-2366:
------------------------------------
Log from running system_tests_http1_adaptor shows release of written buffer, no
drain (proton 0.34.0)
2021-06-11 10:27:38.796401 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_WRITTEN (/home/kgiusti/work/dispatch/qpid\
-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.796422 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_NEED_WRITE_BUFFERS (/home/kgiusti/work/di\
spatch/qpid-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.796521 -0400 HTTP_ADAPTOR (trace) [C1][L15] 16384 request
octets written to server (/home/kgiusti/work/dispatch/qpid-dispatch\
/src/adaptors/http1/http1_server.c:1673)
2021-06-11 10:27:38.796620 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_WRITTEN (/home/kgiusti/work/dispatch/qpid\
-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.796640 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_NEED_WRITE_BUFFERS (/home/kgiusti/work/di\
spatch/qpid-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.796807 -0400 HTTP_ADAPTOR (trace) [C1][L15] 16384 request
octets written to server (/home/kgiusti/work/dispatch/qpid-dispatch\
/src/adaptors/http1/http1_server.c:1673)
2021-06-11 10:27:38.796904 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_WRITTEN (/home/kgiusti/work/dispatch/qpid\
-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.796926 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_NEED_WRITE_BUFFERS (/home/kgiusti/work/di\
spatch/qpid-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.797021 -0400 HTTP_ADAPTOR (trace) [C1][L15] 16384 request
octets written to server (/home/kgiusti/work/dispatch/qpid-dispatch\
/src/adaptors/http1/http1_server.c:1673)
2021-06-11 10:27:38.797097 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_READ (/home/kgiusti/work/dispatch/qpid-di\
spatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.797117 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_CLOSED_READ (/home/kgiusti/work/dispatch/\
qpid-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.797137 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_CLOSED_WRITE (/home/kgiusti/work/dispatch\
/qpid-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.797248 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_WRITTEN (/home/kgiusti/work/dispatch/qpid\
-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.797269 -0400 HTTP_ADAPTOR (trace) [C1] HTTP server proactor
event PN_RAW_CONNECTION_DISCONNECTED (/home/kgiusti/work/dispatch\
/qpid-dispatch/src/adaptors/http1/http1_server.c:525)
2021-06-11 10:27:38.797282 -0400 HTTP_ADAPTOR (info) [C1] Connection closed
(/home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_s\
erver.c:559)
> [c] Raw connection event DRAIN_BUFFERS never arrives
> ----------------------------------------------------
>
> Key: PROTON-2366
> URL: https://issues.apache.org/jira/browse/PROTON-2366
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Environment: Host: Fedora 5.10.16-100.fc32.x86_64;
> gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9)
> Proton git branch main @ 9bf7b7078.
> Dispatch git branch main @ 96182914 with patch shown in Description
> cmake debug build
> Reporter: Charles E. Rolke
> Assignee: Andrew Stitcher
> Priority: Major
>
> Adding support for the drain buffers event in qpid-dispatch reveals that the
> event never arrives in any of the qpid-dispatch tcp self tests. Grepping the
> logs shows 178 CONNECTION_CONNECTED events and 178 CONNECTION_DISCONNECTED
> events but no DRAIN_BUFFERS events.
>
> {code:java}
> diff --git a/src/adaptors/tcp_adaptor.c b/src/adaptors/tcp_adaptor.c
> index 884d0a73..09c0ca9b 100644
> --- a/src/adaptors/tcp_adaptor.c
> +++ b/src/adaptors/tcp_adaptor.c
> @@ -705,6 +705,10 @@ static void handle_connection_event(pn_event_t *e,
> qd_server_t *qd_server, void
> while (qdr_connection_process(conn->qdr_conn)) {}
> break;
> }
> + case PN_RAW_CONNECTION_DRAIN_BUFFERS: {
> + qd_log(log, QD_LOG_CRITICAL, "[C%"PRIu64"]
> PN_RAW_CONNECTION_DRAIN_BUFFERS Event: %d", conn->conn_id, pn_event_type(e));
> + break;
> + }
> default:
> qd_log(log, QD_LOG_DEBUG, "[C%"PRIu64"] Unexpected Event: %d",
> conn->conn_id, pn_event_type(e));
> break;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
