[
https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363178#comment-17363178
]
ASF GitHub Bot commented on DISPATCH-1977:
------------------------------------------
ganeshmurthy commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234648
##########
File path: include/qpid/dispatch/atomic.h
##########
@@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref)
#endif
+#define SET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1)
Review comment:
Introduced a CLEAR_ATOMIC_FLAG macro and the http adaptor now uses it to
clear the flags once a new connection to the server is established.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [http2] adaptor must not call proton functions after pn_raw_connection_close
> ----------------------------------------------------------------------------
>
> Key: DISPATCH-1977
> URL: https://issues.apache.org/jira/browse/DISPATCH-1977
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 1.15.0
> Reporter: Charles E. Rolke
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.17.0
>
>
> Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor
> code.
> The rule is never to call pn_raw_connection_wake or
> pn_raw_connection_write_buffers after calling pn_raw_connection_close.
> The trigger for the failure, at least in the tcp adaptor case, is to close
> the server-side connection while the client-side connection is sending to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
