[
https://issues.apache.org/jira/browse/PROTON-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369584#comment-17369584
] ASF GitHub Bot commented on PROTON-2402: ---------------------------------------- codecov-commenter commented on pull request #324: URL: https://github.com/apache/qpid-proton/pull/324#issuecomment-868692042 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#324](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c834cf) into [main](https://codecov.io/gh/apache/qpid-proton/commit/a3d1ef482c3a5d8cd06775ad4e52be11d50c578c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3d1ef4) will **decrease** coverage by `15.65%`. > The diff coverage is `n/a`. > :exclamation: Current head 5c834cf differs from pull request most recent head 2a10d7a. Consider uploading reports for the commit 2a10d7a to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #324 +/- ## =========================================== - Coverage 68.66% 53.01% -15.66% =========================================== Files 351 46 -305 Lines 70321 2341 -67980 =========================================== - Hits 48285 1241 -47044 + Misses 22036 1100 -20936 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/core/container.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb250YWluZXIucmI=) | `27.35% <0.00%> (-71.75%)` | :arrow_down: | | [ruby/lib/handler/messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfYWRhcHRlci5yYg==) | `28.98% <0.00%> (-68.12%)` | :arrow_down: | | [ruby/lib/core/condition.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25kaXRpb24ucmI=) | `32.25% <0.00%> (-67.75%)` | :arrow_down: | | [ruby/lib/core/connection\_driver.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25uZWN0aW9uX2RyaXZlci5yYg==) | `35.80% <0.00%> (-62.97%)` | :arrow_down: | | [ruby/lib/core/delivery.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9kZWxpdmVyeS5yYg==) | `33.33% <0.00%> (-60.61%)` | :arrow_down: | | [ruby/lib/handler/reactor\_messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9yZWFjdG9yX21lc3NhZ2luZ19hZGFwdGVyLnJi) | `32.55% <0.00%> (-58.14%)` | :arrow_down: | | [ruby/lib/core/receiver.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9yZWNlaXZlci5yYg==) | `44.00% <0.00%> (-56.00%)` | :arrow_down: | | [ruby/lib/core/connection.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25uZWN0aW9uLnJi) | `41.66% <0.00%> (-51.67%)` | :arrow_down: | | [ruby/lib/util/wrapper.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC93cmFwcGVyLnJi) | `43.85% <0.00%> (-50.88%)` | :arrow_down: | | [ruby/lib/core/work\_queue.rb](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS93b3JrX3F1ZXVlLnJi) | `50.00% <0.00%> (-50.00%)` | :arrow_down: | | ... and [323 more](https://codecov.io/gh/apache/qpid-proton/pull/324/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a3d1ef4...2a10d7a](https://codecov.io/gh/apache/qpid-proton/pull/324?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Clarify proton python documentation on thread-safeness and when certain > callbacks are called > -------------------------------------------------------------------------------------------- > > Key: PROTON-2402 > URL: https://issues.apache.org/jira/browse/PROTON-2402 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding > Affects Versions: proton-c-0.34.0 > Reporter: NS-SlaFleur > Priority: Minor > > The Python documentation does not state the following explicitely which > caused some confusion on my end: > - on_settled is triggered on the disposition settled on remote side > - Container & other proton datastructures are NOT thread safe, use injector > for external thread communication > - on_sendable is called on each received flow event & after send if there > are still credits available. > > PR: https://github.com/apache/qpid-proton/pull/324 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
