[
https://issues.apache.org/jira/browse/DISPATCH-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376624#comment-17376624
]
ASF GitHub Bot commented on DISPATCH-2190:
------------------------------------------
jiridanek commented on a change in pull request #1282:
URL: https://github.com/apache/qpid-dispatch/pull/1282#discussion_r665449504
##########
File path: tests/system_tests_qdmanage.py
##########
@@ -86,7 +96,7 @@ def run_qdmanage(self, cmd, input=None,
expect=Process.EXIT_OK, address=None):
try:
p.teardown()
except Exception as e:
- raise Exception(out if out else str(e))
+ raise sys.exc_info()[0](out if out else str(e))
Review comment:
Does `sys.exc_info()[0]` mean `type(e)`?
##########
File path: tests/system_tests_qdmanage.py
##########
@@ -86,7 +96,7 @@ def run_qdmanage(self, cmd, input=None,
expect=Process.EXIT_OK, address=None):
try:
p.teardown()
except Exception as e:
- raise Exception(out if out else str(e))
+ raise sys.exc_info()[0](out if out else str(e))
Review comment:
I'd go for a custom exception class here, probably. `class
QdManageRunError(Exception):` or something like that. It would then allow
expecting this in tests, instead of `RuntimeError`, or something unspecific
like that. But this should serve ok and there is the check on exception message
text, so it should be well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Need a test to verify "ssl-disable-peer-name-verify" qdstat/qdmanage option
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-2190
> URL: https://issues.apache.org/jira/browse/DISPATCH-2190
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tools
> Affects Versions: 1.16.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.17.0
>
>
> Test should:
> # configure SSL/TLS on router listener
> # run qdstat/qdmanage with '127.0.0.1' as server host address
> # confirm qdstat/qdmanage cannot connect
> # re-run qdstat/qdmanage with 127.0.0.1 as server host address AND specify
> --ssl-disable-peer-name-verify option
> # confirm qdstat/qdmanage can connect
> # Profit!!!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
