[
https://issues.apache.org/jira/browse/DISPATCH-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378349#comment-17378349
] ASF GitHub Bot commented on DISPATCH-2191: ------------------------------------------ codecov-commenter commented on pull request #1293: URL: https://github.com/apache/qpid-dispatch/pull/1293#issuecomment-877504733 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1293](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a11f43) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/6d546780da043b72959d6fa65004402e254c75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d54678) will **decrease** coverage by `0.00%`. > The diff coverage is `92.94%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #1293 +/- ## ========================================== - Coverage 84.61% 84.61% -0.01% ========================================== Files 113 113 Lines 28234 28293 +59 ========================================== + Hits 23891 23939 +48 - Misses 4343 4354 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [tests/message\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvbWVzc2FnZV90ZXN0LmM=) | `78.65% <87.50%> (+0.41%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.81% <100.00%> (+0.18%)` | :arrow_up: | | [src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FsbG9jX3Bvb2wuYw==) | `88.37% <0.00%> (-5.32%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.53% <0.00%> (-0.22%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-0.17%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (ø)` | | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.44% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.69% <0.00%> (+0.28%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.88% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.56% <0.00%> (+0.96%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6d54678...4a11f43](https://codecov.io/gh/apache/qpid-dispatch/pull/1293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Count only body buffers when considering q2. Do not count header buffers > ------------------------------------------------------------------------- > > Key: DISPATCH-2191 > URL: https://issues.apache.org/jira/browse/DISPATCH-2191 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container > Affects Versions: 1.16.1 > Reporter: Ganesh Murthy > Assignee: Ken Giusti > Priority: Major > > Consider a two router case where QD_QLIMIT_Q2_UPPER is set to 32 and > QD_QLIMIT_Q2_LOWER is set to 16. > The router B receives a large message from from router A. The first two > buffers of the message consists of header and properties respectively. This > is followed by a 16 buffer body data which is followed by a 15 buffer body > data. There are 33 buffers in total. The application code frees the first > body data but that frees only 15 buffers because the second body data starts > in the last buffer of the first body data. > Out of the original 33 buffers, 15 have been freed which means the number of > buffers remaining in the message content is 18 which is greater than > QD_QLIMIT_Q2_LOWER. So we remain in q2 and the second body data is not fully > received. > > This situation can be alleviated by not counting the header buffer towards > the q2. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
