[
https://issues.apache.org/jira/browse/QPID-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379381#comment-17379381
]
ASF GitHub Bot commented on QPID-8545:
--------------------------------------
dakirily commented on a change in pull request #98:
URL: https://github.com/apache/qpid-broker-j/pull/98#discussion_r668159922
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnectionTLSDelegate.java
##########
@@ -310,6 +337,11 @@ private int wrapBufferArray(Collection<QpidByteBuffer>
buffers) throws SSLExcept
}
while(encrypted && _sslEngine.getHandshakeStatus() !=
SSLEngineResult.HandshakeStatus.NEED_UNWRAP);
+ if (enableDiagnosisOfSslEngineLooping)
Review comment:
Hi Alex,
I agree, connection looping was happening inside of both
`NonBlockingConnection` and `NonBlockingConnectionTLSDelegate`. It also
happened either when initiating SSL connection or when disconnecting. So
checking whether data was written into the output buffer or not seems to be
right solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [Broker-J] SSL Engine looping circuit breaker
> ---------------------------------------------
>
> Key: QPID-8545
> URL: https://issues.apache.org/jira/browse/QPID-8545
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-8.0.5
> Reporter: Daniil Kirilyuk
> Priority: Minor
>
> A configurable circuit breaker should be added to
> NonBlockingConnectionTLSDelegate giving the possibility to stop SSL engine
> looping (QPID-8526, QPID-8489).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
