[
https://issues.apache.org/jira/browse/DISPATCH-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380496#comment-17380496
] ASF GitHub Bot commented on DISPATCH-2077: ------------------------------------------ codecov-commenter commented on pull request #1297: URL: https://github.com/apache/qpid-dispatch/pull/1297#issuecomment-879789499 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1297](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5768d58) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/269bfd46f3ac43ef6d1199f8cb271d117fd1ed9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (269bfd4) will **decrease** coverage by `0.08%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #1297 +/- ## ========================================== - Coverage 84.74% 84.66% -0.09% ========================================== Files 113 113 Lines 28268 28268 ========================================== - Hits 23956 23932 -24 - Misses 4312 4336 +24 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RpbWVyLmM=) | `96.82% <100.00%> (-0.03%)` | :arrow_down: | | [tests/test-receiver.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1yZWNlaXZlci5j) | `69.15% <0.00%> (-2.81%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.36% <0.00%> (-1.81%)` | :arrow_down: | | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0.00%> (-1.58%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.56% <0.00%> (-0.49%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.39% <0.00%> (-0.22%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-0.17%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.63% <0.00%> (-0.08%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.88% <0.00%> (ø)` | | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.64% <0.00%> (+0.19%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1297/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [269bfd4...5768d58](https://codecov.io/gh/apache/qpid-dispatch/pull/1297?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Replace usage of `clock_gettime` in `qd_timer_now` with `pn_proactor_now_64` > from Proton > ---------------------------------------------------------------------------------------- > > Key: DISPATCH-2077 > URL: https://issues.apache.org/jira/browse/DISPATCH-2077 > Project: Qpid Dispatch > Issue Type: Sub-task > Reporter: Jiri Daněk > Assignee: Jiri Daněk > Priority: Major > Fix For: 1.17.0 > > > *Assignee: Ankit Aggarwal* > If you take a look into Proton how {{pn_proactor_now_64}} is implemented, you > will see there are actually three implementations that are used depending on > platform. One of the implementations is a Windows one, btw ;P > This is part of solving the issue "[Qpid-dispatch] timespec not defined on > Windows" described at > http://qpid.2158936.n2.nabble.com/Qpid-dispatch-timespec-not-defined-on-Windows-td7642532.html > See discussion "C types for timestamps and durations" for more background > http://qpid.2158936.n2.nabble.com/C-types-for-timestamps-and-durations-td7682395.html -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
