[
https://issues.apache.org/jira/browse/DISPATCH-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380502#comment-17380502
]
ASF GitHub Bot commented on DISPATCH-1783:
------------------------------------------
jiridanek edited a comment on pull request #1296:
URL: https://github.com/apache/qpid-dispatch/pull/1296#issuecomment-879794387
First pass/fail check that would make sense to me: ensure that the ratio
between the direct case (without router) and the one with router is not too
big. (The multiple tests with the router are pretty much the same, the tests
only differ in implementation details; I am experimenting with multiple
possibilities how to write it).
```
76:
--------------------------------------------------------------------------------
76: Benchmark Time CPU
Iterations
76:
--------------------------------------------------------------------------------
76: BM_TCPEchoServerLatencyWithoutQDR 0.037 ms 0.019 ms
35901
76: BM_TCPEchoServerLatency1QDRThread 0.339 ms 0.032 ms
10000
76: BM_TCPEchoServerLatency1QDRThread2 0.341 ms 0.033 ms
10000
76: BM_TCPEchoServerLatency1QDRSubprocess 0.341 ms 0.034 ms
10000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add ability to use test doubles (mocks, fakes, ...) in C tests
> --------------------------------------------------------------
>
> Key: DISPATCH-1783
> URL: https://issues.apache.org/jira/browse/DISPATCH-1783
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.14.0
> Reporter: Jiri Daněk
> Priority: Major
>
> During the work on https://github.com/apache/qpid-dispatch/pull/684, there
> was at one point a version of the PR, which tested what happens if
> {{vsnprintf}} called from {{safe_snprinf}} returns {{-1}}.
> This was done by replacing the {{vsnprintf}} with a mock (technically it's
> probably a stub, or maybe fake, but let's ignore the proper terminology).
> There are various possibilities how to approach mocking in C. They are less
> nice than in more dynamic languages such as Java, or even C++ (where it's
> possible to subclass things). Nevertheless, it can be useful technique, and
> it should be explored.
> CC [~cans]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
