[
https://issues.apache.org/jira/browse/QPID-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382237#comment-17382237
]
ASF GitHub Bot commented on QPID-8549:
--------------------------------------
dakirily commented on pull request #100:
URL: https://github.com/apache/qpid-broker-j/pull/100#issuecomment-881612281
In BDBConfiguredObjectRecord toString() was refactored to use
String.format().
In SortedQueueEntryList null check for parent entry was changed to throw an
exception. Would it be OK or would you prefer to leave to existing logic
without any changes at all?
In MultiVersionProtocolEngine null check for supportedReplyBytes was
extended with the logic suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [Broker-J] HP Fortify: Null de-reference
> ----------------------------------------
>
> Key: QPID-8549
> URL: https://issues.apache.org/jira/browse/QPID-8549
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-8.0.5
> Reporter: Daniil Kirilyuk
> Priority: Minor
>
> HP Fortify complains about several places where a null might get
> de-referenced:
> broker-core/src/main/java/org/apache/qpid/server/transport/MultiVersionProtocolEngine.java
> 467 - Assigned null : supportedReplyVersion
> Can be refactored to String.valueOf()
> 469 - Dereferenced : supportedReplyBytes
> broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java
> 957 - Dereferenced : soleConnectionEnforcementPolicy
> 968 - Dereferenced : soleConnectionEnforcementPolicy
> broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java
> 282 - Dereferenced : consumer
> broker-core/src/main/java/org/apache/qpid/server/queue/SortedQueueEntryList.java
> 113 - Dereferenced : parent
> 122 - Dereferenced : parent
> tools/src/main/java/org/apache/qpid/tools/StressTestClient.java
> 409 - Dereferenced : consumer
> tools/src/main/java/org/apache/qpid/tools/util/ArgumentsParser.java
> 166 - Dereferenced : defaultValue
> broker-plugins/amqp-1-0-protocol/src/main/org/apache/qpid/server/protocol/v1_0/ConsumerTarget_1_0.java
> 489 - Dereferenced : txn
> 508 - Dereferenced : txn
> 536 - Dereferenced : txn
> 557 - Dereferenced : txn
> 592 - Dereferenced : txn
> bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBConfiguredObjectRecord.java
> 114 - Dereferenced :
> broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/MessageConverter_from_1_0.java
> 92 - Dereferenced : sections
> broker-core/src/main/java/org/apache/qpid/server/queue/DefinedGroupMessageGroupManager.java
> 259 - Dereferenced : messageHeader
> 260 - Dereferenced : messageHeader
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
