[
https://issues.apache.org/jira/browse/DISPATCH-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385809#comment-17385809
]
ASF GitHub Bot commented on DISPATCH-2037:
------------------------------------------
codecov-commenter commented on pull request #1314:
URL: https://github.com/apache/qpid-dispatch/pull/1314#issuecomment-885288073
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1314](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(72a5ab7) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/e730673d4ab3f71720a9e4295b06239950bc9456?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e730673) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
+ Coverage 84.65% 84.68% +0.02%
==========================================
Files 113 113
Lines 28323 28345 +22
==========================================
+ Hits 23977 24003 +26
+ Misses 4346 4342 -4
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.75% <0.00%> (-0.65%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.33% <0.00%> (-0.56%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `92.64% <0.00%> (-0.40%)` | :arrow_down: |
|
[include/qpid/dispatch/atomic.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2F0b21pYy5o)
| `100.00% <0.00%> (ø)` | |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `88.13% <0.00%> (+0.18%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.48% <0.00%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `90.73% <0.00%> (+0.29%)` | :arrow_up: |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `85.14% <0.00%> (+0.99%)` | :arrow_up: |
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `82.84% <0.00%> (+4.14%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[e730673...72a5ab7](https://codecov.io/gh/apache/qpid-dispatch/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [http2] Thread race accessing qdr_http2_connection_t pings in
> system_tests_http2
> --------------------------------------------------------------------------------
>
> Key: DISPATCH-2037
> URL: https://issues.apache.org/jira/browse/DISPATCH-2037
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Jiri Daněk
> Assignee: Ganesh Murthy
> Priority: Major
> Labels: race-condition, tsan
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/496286761#L6889
> {noformat}
> 68: WARNING: ThreadSanitizer: data race (pid=16868)
> 68: Read of size 8 at 0x7b4800005fb0 by thread T4:
> 68: #0 egress_conn_ping_sender
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2228
> (libqpid-dispatch.so+0xf3c6d)
> 68: #1 egress_conn_ping_sender
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2206
> (libqpid-dispatch.so+0xf3c6d)
> 68: #2 qd_timer_visit
> /home/travis/build/apache/qpid-dispatch/src/timer.c:205
> (libqpid-dispatch.so+0xefbd7)
> 68: #3 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1008
> (libqpid-dispatch.so+0xea5de)
> 68: #4 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122
> (libqpid-dispatch.so+0xec477)
> 68: #5 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174
> (libqpid-dispatch.so+0x94e86)
> 68: #6 <null> <null> (libtsan.so.0+0x2d1af)
> 68:
> 68: Previous write of size 8 at 0x7b4800005fb0 by thread T3:
> 68: #0 handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2447
> (libqpid-dispatch.so+0xfe9fd)
> 68: #1 handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:804
> (libqpid-dispatch.so+0xea569)
> 68: #2 do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:810
> (libqpid-dispatch.so+0xea569)
> 68: #3 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1090
> (libqpid-dispatch.so+0xea569)
> 68: #4 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122
> (libqpid-dispatch.so+0xec477)
> 68: #5 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174
> (libqpid-dispatch.so+0x94e86)
> 68: #6 <null> <null> (libtsan.so.0+0x2d1af)
> 68:
> 68: Location is heap block of size 384 at 0x7b4800005e80 allocated by main
> thread:
> 68: #0 posix_memalign <null> (libtsan.so.0+0x3048d)
> 68: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:395
> (libqpid-dispatch.so+0x5f5d4)
> 68: #2 new_qdr_http2_connection_t
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:52
> (libqpid-dispatch.so+0xf66c5)
> 68: #3 qdr_http_connection_egress
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2312
> (libqpid-dispatch.so+0xfece5)
> 68: #4 qd_http2_configure_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2584
> (libqpid-dispatch.so+0xffdfc)
> 68: #5 qd_dispatch_configure_http_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http_common.c:172
> (libqpid-dispatch.so+0x3eebd)
> 68: #6 <null> <null> (libffi.so.7+0x6ff4)
> 68: #7 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 68: #8 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 68:
> 68: Thread T4 (tid=16873, running) created by main thread at:
> 68: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
> 68: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183
> (libqpid-dispatch.so+0x95442)
> 68: #2 qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485
> (libqpid-dispatch.so+0xeceda)
> 68: #3 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x2c27)
> 68: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 68:
> 68: Thread T3 (tid=16872, running) created by main thread at:
> 68: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
> 68: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183
> (libqpid-dispatch.so+0x95442)
> 68: #2 qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485
> (libqpid-dispatch.so+0xeceda)
> 68: #3 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x2c27)
> 68: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 68:
> 68: SUMMARY: ThreadSanitizer: data race
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2228
> in egress_conn_ping_sender
> 68: ==================
> 68: ThreadSanitizer: reported 1 warnings
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
