[
https://issues.apache.org/jira/browse/DISPATCH-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386293#comment-17386293
]
ASF GitHub Bot commented on DISPATCH-2209:
------------------------------------------
kgiusti edited a comment on pull request #1312:
URL: https://github.com/apache/qpid-dispatch/pull/1312#issuecomment-885708751
> Do we need :method and :status as separate properties if they are also
conveyed in subject for request and response respectively?
@grs you're correct - the app properties are duplicate. However IIUC the
HTTP/2 adaptor also puts :method and :status in the app properties BUT doesn't
set a Subject property at all.
@ganeshmurthy what do you think: in the HTTP/1 adaptor, the AMQP Subject
property contains the request method (e.g. GET) in the AMQP mapping for a
request message, and sets Subject to the response code (:status, e.g. 200) in
the response AMQP message.
Should both adaptors remove the :status and :method app properties and just
use the Subject field instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> HTTP/1.x - fix meta-headers types and values for consistency with HTTP/2
> ------------------------------------------------------------------------
>
> Key: DISPATCH-2209
> URL: https://issues.apache.org/jira/browse/DISPATCH-2209
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 1.16.1
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.17.0
>
>
> {{The meta-data used when mapping to/from AMQP should be:}}
> {{ Message Properties Section: }}
> {{ HTTP Message AMQP Message Properties }}
> {{ ------------ ----------------------- }}
> {{ Request Method subject field (request message) }}
> {{ Response Status code subject field (response message) }}
> {{ Application Properties Section: }}
> {{ HTTP Message AMQP Message App Properties Map }}
> {{ ------------ ------------------------------- }}
> {{ Request Method ":method": <string> }}
> {{ Message Version ":version": <version|"1.1" by default> }}
> {{ Response Status Code ":status": <string> (response only) }}
> {{ Response Reason ":reason": <string> (response only) }}
> {{ Request Target ":path": <string> }}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
