Agreed it should be more robust. I'd like to get through this first pull
process and then can go back and make it better.
From: Dan Debrunner <[email protected]>
To: "[email protected]" <[email protected]>
Sent: Tuesday, March 8, 2016 10:32 AM
Subject: Re: incubator-quarks git commit: QUARKS-6 updated objectname for
jobmxbean
On Tuesday, March 8, 2016 10:21 AM, "[email protected]" <[email protected]>
wrote:
>
> StringBuffer sbuf = new StringBuffer();
>- sbuf.append("*:interface=");
>+ sbuf.append("*:alias=*");
>+ sbuf.append(",interface=");
> sbuf.append(ObjectName.quote("quarks.execution.mbeans.JobMXBean"));
> sbuf.append(",type=");
> sbuf.append(ObjectName.quote("job"));
Looking at the docs for ObjectName I think the pattern could be more robust to
changes by just looking for the keys that you need to find a job, rather than
every key that might be in the name. E.g. see this example from the javadoc:
d:type=Foo,name=Bar,* to match names in the domain d that have the keys
type=Foo,name=Bar plus zero or more other keys.
Dan.
