[
https://issues.apache.org/jira/browse/QUARKS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190266#comment-15190266
]
Susan L. Cline edited comment on QUARKS-15 at 3/11/16 1:09 AM:
---------------------------------------------------------------
Also, I wanted to add to the above for the process of committing. What happens
when you wait for the commit notice and someone does have a comment that needs
to be addressed in the code. So following along above, when you get to this
step:
git push --set-upstream origin console_hover_text – whatever your branch name
is
...
Now look for the commit notice, hang out on the dev list to see if anyone has
objections or wants to discuss the commit
What you do next to address any issues in the code is this:
1) make your changes to address the issue
2) git add <the changes>
3) git commit -m 'comments that you fixed any issues raised'
4) git push
after that, you again wait to see if anyone has any comments on the commit. If
not, proceed as above making the pull:
git checkout master
git pull --rebase
git checkout console_hover_text – your branch name
git rebase master
git checkout master
git log – this is the part I am not sure about, Luciano mentioned to check this
.. I don't really understand this. I don't see an entry here for this commit.
Is that good?
.... finish the rest of the steps above.
was (Author: home4slc):
Also, I wanted to add to the above process of committing what happens when you
do wait for the commit notice and someone has a comment that needs to be
addressed in the code. So following along above, when you get to this step:
git push --set-upstream origin console_hover_text – whatever your branch name
is
...
Now look for the commit notice, hang out on the dev list to see if anyone has
objections or wants to discuss the commit
What you do next to address any issues in the code is this:
1) make your changes to address the issue
2) git add <the changes>
3) git commit -m 'comments that you fixed any issues raised'
4) git push
after that, you again wait to see if anyone has any comments on the commit. If
not, proceed as above making the pull:
git checkout master
git pull --rebase
git checkout console_hover_text – your branch name
git rebase master
git checkout master
git log – this is the part I am not sure about, Luciano mentioned to check this
.. I don't really understand this. I don't see an entry here for this commit.
Is that good?
.... finish the rest of the steps above.
> Document commit process
> -----------------------
>
> Key: QUARKS-15
> URL: https://issues.apache.org/jira/browse/QUARKS-15
> Project: Quarks
> Issue Type: Improvement
> Components: Documentation
> Reporter: Susan L. Cline
> Assignee: Susan L. Cline
> Priority: Minor
> Labels: commit, documentation,
> Attachments: committing_files.txt
>
>
> Attached is a text file of an example I went through to commit and pull files
> as a committer on quarks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
