Github user ddebrunner commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/9#discussion_r56062476
  
    --- Diff: runtime/etiao/src/main/java/quarks/runtime/etiao/EtiaoJob.java ---
    @@ -51,6 +53,10 @@ public EtiaoJob(DirectGraph graph, String topologyName, 
ServiceContainer contain
             ControlService cs = container.getService(ControlService.class);
             if (cs != null)
                 cs.registerControl(JobMXBean.TYPE, getId(), getName(), 
JobMXBean.class, new EtiaoJobBean(this));
    +        
    +        this.jobs = (JobRegistry) 
container.getService(JobRegistryService.class);
    --- End diff --
    
    Maybe then it's the sole responsibility of the runtime to register a 
JobRegistry and thus JobRegistry would not be a public class, but instead an 
implementation detail
    
    Then it would not be expected that external code registers a 
JobRegistryService .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to