Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/11#discussion_r56185779
--- Diff:
spi/topology/src/main/java/quarks/topology/spi/graph/ConnectorStream.java ---
@@ -96,6 +89,35 @@ protected Graph graph() {
}
@Override
+ public <E extends Enum<E>> EnumMap<E,TStream<T>> split(Class<E>
enumClass, Function<T, E> splitter) {
+
+ E[] es = enumClass.getEnumConstants();
+
+/*
+ List<TStream<T>> outputs = split(es.length, e ->
IntStream.range(0, es.length).filter(i-> es[i].equals(splitter.apply(e)))
+ .mapToObj(i -> es[i].ordinal()).findAny().orElse(-1));
+*/
+
+ List<TStream<T>> outputs = split(es.length, new ToIntFunction<T>()
{
+ @Override
+ public int applyAsInt(T input) {
+ for(int i = 0; i < es.length; i++){
--- End diff --
I was also going to comment on simplifying the fn. And (then eliminating
the need for the intermediate "es" variable) I think the returnMap construction
could be simplified to:
```
for (E e : enumClass.getEnumConstants()) {
returnMap.put(e, outputs.get(e.ordinal());
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
