[
https://issues.apache.org/jira/browse/QUARKS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195517#comment-15195517
]
ASF GitHub Bot commented on QUARKS-18:
--------------------------------------
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/11#discussion_r56186378
--- Diff: api/topology/src/main/java/quarks/topology/TStream.java ---
@@ -4,18 +4,15 @@
*/
package quarks.topology;
+import quarks.function.*;
--- End diff --
We don't have a formal coding style doc but the rest of the code uses
explicit imports instead of wildcards. Generally, it's best to avoid arbitrary
changes when introducing new functionality. Generally, nice work btw.
> Split function based upon an enumeration.
> -----------------------------------------
>
> Key: QUARKS-18
> URL: https://issues.apache.org/jira/browse/QUARKS-18
> Project: Quarks
> Issue Type: Improvement
> Components: API
> Reporter: Daniel John Debrunner
> Priority: Minor
> Labels: newbie
> Attachments: SplitWithEnum_Screenshot.png
>
>
> An enum based split would be useful.
> Something like:
> <E> List<TStream<T>> split(Class<E> enumClass, Function<T,E> splitter)
> So the stream is split by the enum value with the returned streams in ordinal
> order.
> This may have the benefit of being self-maintaining, so that if an enum value
> is added, the returned number of streams changes automatically, but only if
> given an enum class one can figure out the number of enums.
> Based upon looking at the sample code in QUARKS-16
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
