[
https://issues.apache.org/jira/browse/QUARKS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200078#comment-15200078
]
ASF GitHub Bot commented on QUARKS-39:
--------------------------------------
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/23#discussion_r56551534
--- Diff:
samples/topology/src/main/java/quarks/samples/topology/CombiningStreamsProcessingResults.java
---
@@ -63,6 +63,7 @@ public static void main(String[] args) throws Exception {
// Split the stream by blood pressure category
List<TStream<Map<String, Integer>>> categories = readings.split(6,
new ToIntFunction<Map<String, Integer>>() {
+ private static final long serialVersionUID = 1L;
--- End diff --
@queeniema pls adjust this post merge if desired. You should be able to
replace the `new` with a lambda fn and simplify things. e.g., something like
```
... readings.split(6, tuple -> {
if (tuple.get("Systolic") < 120 && ...
// Normal
return 0;
} else if ...
...
});
```
> Java warnings creaping in
> -------------------------
>
> Key: QUARKS-39
> URL: https://issues.apache.org/jira/browse/QUARKS-39
> Project: Quarks
> Issue Type: Bug
> Reporter: Dale LaBossiere
> Assignee: Dale LaBossiere
> Priority: Trivial
>
> I couple of recent merges have introduced some java warnings -- currently at
> 4. I'll clean them up.
> Please try to be more diligent about keeping these out of the code base :-)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
