Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/23#discussion_r56551534
  
    --- Diff: 
samples/topology/src/main/java/quarks/samples/topology/CombiningStreamsProcessingResults.java
 ---
    @@ -63,6 +63,7 @@ public static void main(String[] args) throws Exception {
     
             // Split the stream by blood pressure category
             List<TStream<Map<String, Integer>>> categories = readings.split(6, 
new ToIntFunction<Map<String, Integer>>() {
    +            private static final long serialVersionUID = 1L;
    --- End diff --
    
    @queeniema pls adjust this post merge if desired.   You should be able to 
replace the `new` with a lambda fn and simplify things.  e.g., something like
    ```
      ... readings.split(6, tuple -> {
                            if (tuple.get("Systolic") < 120 && ...
                                // Normal
                                return 0;
                            }  else if ...
                            ...
                        });
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to