[
https://issues.apache.org/jira/browse/QUARKS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211884#comment-15211884
]
Dale LaBossiere commented on QUARKS-80:
---------------------------------------
I agree with [~djd]'s sentiment. That said, the user’s function is doing a
form of aggregation regardless of which method is used so aggregate() vs
batch() seems a little confusing. As noted, the differences are the conditions
under which the user supplied fn is called.
I’m not sure renaming will make enough of a difference to warrant it but offer
a couple of other alternatives in case there’s still interest in that:
- aggregate() and batch[ed]Aggregate() or aggregateBatch().
- process() and batch[ed]Process() or processBatch()
- process() and batch()
> The TWindow.aggregate name could be imporoved
> ---------------------------------------------
>
> Key: QUARKS-80
> URL: https://issues.apache.org/jira/browse/QUARKS-80
> Project: Quarks
> Issue Type: Improvement
> Reporter: Will Marshall
> Assignee: Will Marshall
> Priority: Minor
>
> For example, TWindow.batch clearly provides batch functionality for tuples in
> the partition -- tuples are processed in bulk, and then evicted.
> The contract for TWindow.aggregate is less clear given the name. The way it
> currently works, the partition is aggregated any time its contents change (a
> tuple is inserted or evicted).
> Perhaps something like TWindow.aggregateOnChange would be better?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
