Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/49#discussion_r57585702
--- Diff:
test/svt/src/main/java/quarks/test/svt/utils/sensor/gps/GpsSensor.java ---
@@ -0,0 +1,75 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+package quarks.test.svt.utils.sensor.gps;
+
+public class GpsSensor {
--- End diff --
Based on how this seems to be used (e.g., `TStream<GpsSensor>`), the class
name seems misleading. It's not a sensor it's a sensor sample / reading,
right? Similarly SimulatedGpsSensor.getSensor() could be named something
clearer - perhaps `readings()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
