Thank you for check, Justin I will use Apache Rat when checking license issue, it looks very helpful. I created a PR that include missing headers to repo you mentioned immediatly. And I will make sure what license using in sankey_quarks.js
And hmm I think we can hegde JAR issue by using dependency management tool like maven. But I cannot be sure due to lack of experience. If I can be more help, please tell me 2016. 4. 8. 오전 9:25에 "Justin Mclean" <[email protected]>님이 작성: > Hi, > > Apologies if any of this has come up on the list before and again for > being a bit late to the party. > > I just tool al look at the source code in the pro to check the licensing. > If you not aware of it Apache Rat is a tool that checks headers and source > releases for license issues [1] So I ran rat and a few other tools (grep > basically) over the current code base and here's what I found. > > The following files are missing Apache headers: > > ./samples/scenarios/src/main/java/quarks/samples/scenarios/iotf/IotfFullScenario.java > ./console/servlets/webapp_content/js/ext/sankey_quarks.js (may not be > Apache licensed) > ./console/servlets/webapp_content/js/graph.js > ./console/servlets/webapp_content/js/index.js > ./console/servlets/webapp_content/js/metrics.js > > Currently we have several jars checked into version control that’s rather > unusual. Jars can’t be included in a source release, are are usually > included at build time, and are usually not stored in version control. > > I can see the following 3rd party code in the repo: > - D3 Legend MIT licensed > - D3 BSD licensed > - JQuery UI MIT licensed > - Sankey [2] may be based on this [3] whose license is BSD but is missing > a header > - Apache Commons Math. This has a notice file that would effect our notice > file if bundled [4] > - Google Gson Apache licensed missing NOTICE file > - Metrics Apache license with NOTICE file [5] > - slf4j MIT licensed > > Is there anything I’ve missed? > > Depending on how this code is used i.e. bundled or brought in at run time > it’s going to change the contents of our LICENSE and NOTICE files. > > I didn’t look at the jars in detail. I can see mostly Apache with a Scala > BSD and there also some EPL and MPL licensed code in that that may need to > be handled carefully [6] > > Thanks, > Justin > > 1. http://creadur.apache.org/rat/ > 2. ./console/servlets/webapp_content/js/ext/sankey_quarks.js > 3. https://github.com/d3/d3-plugins/blob/master/sankey/sankey.js > 4. https://github.com/apache/commons-math/blob/master/NOTICE.txt > 5. https://github.com/dropwizard/metrics/blob/3.1-maintenance/NOTICE > 6. http://www.apache.org/legal/resolved.html#category-b > >
