[
https://issues.apache.org/jira/browse/QUARKS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235350#comment-15235350
]
ASF GitHub Bot commented on QUARKS-129:
---------------------------------------
GitHub user dlaboss opened a pull request:
https://github.com/apache/incubator-quarks/pull/84
[QUARKS-129] create SimpleSimulatedSensor
@queeniema, pls review to ensure this meets your needs/expectations. Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlaboss/incubator-quarks
quarks129-renameSimulatedTemperatureSensor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit d56ce0ae63b1abe3376479cbfd8369d880f0c453
Author: Dale LaBossiere <[email protected]>
Date: 2016-04-11T15:55:08Z
[QUARKS-129] create SimpleSimulatedSensor
----
> rename SimulatedTemperatureSensor to facilitate reuse
> -----------------------------------------------------
>
> Key: QUARKS-129
> URL: https://issues.apache.org/jira/browse/QUARKS-129
> Project: Quarks
> Issue Type: Improvement
> Components: Samples
> Reporter: Dale LaBossiere
> Assignee: Dale LaBossiere
> Priority: Minor
> Labels: newbie
>
> There's nothing about temperature specific about
> quarks.samples.utils.sensor.SimulatedTemperatureSensor. In fact the same
> basic code is used for a gas-mileage sensor in
> recipe_different_processing_against_stream.md.
> Rename this facilitate more reuse.
> Not sure of a good name.
> Maybe SimpleRandomDeltaSensor or such.
> Consider updating that recipe to use it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
