Github user ddebrunner commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/93#discussion_r60313992
  
    --- Diff: 
analytics/sensors/src/main/java/quarks/analytics/sensors/Valve.java ---
    @@ -0,0 +1,91 @@
    +package quarks.analytics.sensors;
    +
    +import java.util.Objects;
    +
    +import quarks.function.Predicate;
    +
    +/**
    + * A generic "valve" {@link Predicate}.
    + * <p>
    + * A valve predicate accepts tuples when its state is {@link State#OPEN},
    + * otherwise it rejects tuples.
    --- End diff --
    
    maybe discards or ignores tuples, it doesn't really 'reject' them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to