[
https://issues.apache.org/jira/browse/QUARKS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252580#comment-15252580
]
ASF GitHub Bot commented on QUARKS-146:
---------------------------------------
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/96#discussion_r60647114
--- Diff:
connectors/iotf/src/main/java/quarks/connectors/iotf/runtime/IotfDeviceCommands.java
---
@@ -41,8 +45,7 @@ public void accept(Consumer<Command> commandSubmitter) {
try {
connector.subscribeCommands(commandSubmitter);
} catch (Exception e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
+ logger.error("Exception caught while subscribing
commands: {}", e);
--- End diff --
Coding conventions are missing from DEVELOPMENT.md but that effort is
underway (e.g., QUARKS-23).
For the most part the code uses spaces instead of hard tabs, with 4 spaces
of indentation. (the above may be changing that to 2). Please remove the hard
tabs.
The ": {}" in the error() msg string needs to be removed here and in other
cases below.
I noticed that the sample use that I pointed you at in JobRegistry had that
problem (I notified the author). Sorry about that.
Thanks for your help!
> cleanup e.printStackTrace() use
> -------------------------------
>
> Key: QUARKS-146
> URL: https://issues.apache.org/jira/browse/QUARKS-146
> Project: Quarks
> Issue Type: Bug
> Components: Runtime
> Reporter: Dale LaBossiere
> Priority: Minor
> Labels: newbie
>
> Ran across a use of e.printStackTrace() in runtime code where logging needs
> to be done instead. Looks like there are a few instances of this:
> AppServiceControl.java
> Executable.java
> Invocation.java
> IotfDeviceCommands.java
> There are also numerous uses in console/servlets. Do those need to be fixed
> too?
> $ cd incubator-quarks
> $ grep printStackTrace `find . -name *.java | grep -v test`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
