[
https://issues.apache.org/jira/browse/QUARKS-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257187#comment-15257187
]
ASF GitHub Bot commented on QUARKS-131:
---------------------------------------
Github user vdogaru commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/86#discussion_r61002673
--- Diff: api/oplet/src/main/java/quarks/oplet/core/PeriodicSource.java ---
@@ -47,8 +48,8 @@ public void initialize(OpletContext<Void, T> context) {
public synchronized void start() {
ControlService cs =
getOpletContext().getService(ControlService.class);
if (cs != null)
- cs.registerControl("periodic",
getOpletContext().uniquify(getClass().getSimpleName()),
- getAlias(), PeriodicMXBean.class, this);
+ cs.registerControl(TStream.TYPE,
getOpletContext().uniquify(getClass().getSimpleName()),
--- End diff --
Would it make sense to register the control against a class type rather
than a String? Instead of:
`<T> String registerControl(String type, String id, String alias, Class<T>
controlInterface, T control);` where
the `type` parameter identifies the type of the control MBean, use:
`<T> String registerControl(Class<?> type, String id, String alias,
Class<T> controlInterface, T control);` where the `type` parameter is the type
of object controlled by the MBean.
> need easy way to get PeriodicMXBean associated with a poll() invocation
> -----------------------------------------------------------------------
>
> Key: QUARKS-131
> URL: https://issues.apache.org/jira/browse/QUARKS-131
> Project: Quarks
> Issue Type: Improvement
> Reporter: Dale LaBossiere
> Assignee: Dale LaBossiere
>
> I think we're missing some API is missing to make this all usable.
> A Topology/TStream domain user needs an easy way to get the PeriodicMXBean
> for a particular Topology.poll() invocation.
> The PeriodicSource oplet implements PeriodicMXBean which allows changing the
> period.
> The only demonstrated use is by
> DirectJobTest.jobPeriodicSourceCancellation(), which iterates over the
> Topology's underlying graph for instanceof PeriodicSource oplet (it's the
> only ProcessSource oplet in the graph for this test).
> That's certainly not easy / convenient / nor in the "TStream" domain the user
> is mostly operating in.
> [~djd] [~vdogaru] what schemes for addressing this have already been
> considered / decided? Some sort of "control bean registry service" where a
> user gets to supply a name (e.g., to poll()) and the runtime registers the
> bean (e.g., PeriodicMXBean) under that name? If there's not a concrete plan
> lets work on that here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
