[ 
https://issues.apache.org/jira/browse/QUARKS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268829#comment-15268829
 ] 

ASF GitHub Bot commented on QUARKS-164:
---------------------------------------

GitHub user Cazen opened a pull request:

    https://github.com/apache/incubator-quarks-website/pull/57

    [QUARKS-164] Navigation menu works the wrong way

    I think that "Closes the Responsive Menu on Menu Item Click" function is 
unnecessary.
    Mobile device that receives a "touch input" doesn't have "mouse over". So 
we should click on 1depth menu if wanna to see a 2depth menu. But in case of 
that, nav-bar will be collapsed. 
    landing-page.js seems that used index.html only.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks-website QUARKS-164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks-website/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 88b91ab600ea7bc25485ec4cf5ed3923b737d314
Author: cazen.lee <[email protected]>
Date:   2016-05-03T09:29:13Z

    remove "Closes the Responsive Menu on Menu Item Click" function

----


> Navigation menu works the wrong way
> -----------------------------------
>
>                 Key: QUARKS-164
>                 URL: https://issues.apache.org/jira/browse/QUARKS-164
>             Project: Quarks
>          Issue Type: Bug
>          Components: Web Site
>            Reporter: Cazen Lee
>            Assignee: Cazen Lee
>            Priority: Minor
>
> Navigation menu(black areas in our website. it has Home, About Quarks, 
> Community, Getting Started, etc) seems that works the wrong way in mobile 
> site.
> It works properly when larger screen device but in case of mobile device(I've 
> tested my android phone) works unintentional collapse when I clicked submenu.
> About Quarks or Community(its 1depth menu) has their own 2depth menu like 
> below:
> |Home |About Quarks| About Quarks
> |-|-|License|
> |-|Community|Get Involved|
> |-|-|Issue Tracker|
> |-|-|Source Code|
> So, When I click on, the 2 depth menu should be shown instead of the 
> collapsing whole menu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to