Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/106#discussion_r63770525
  
    --- Diff: 
connectors/http/src/test/java/quarks/test/connectors/http/HttpTest.java ---
    @@ -80,9 +154,9 @@ public void testStatusCode() throws Exception {
             
             String url = "http://httpbin.org/status/";;
             
    +        TStream<Integer> stream = topology.collection(Arrays.asList(200, 
404, 202));
    --- End diff --
    
    Just to clarify, when I mentioned pulling the declaration of the `stream` 
outside of the request() invocation, I was only talking about for the samples 
in the javadoc.  It's OK that test code had it that way.  But it's fine to 
leave it this way now.  Sorry for the confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to