[ 
https://issues.apache.org/jira/browse/QUARKS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302935#comment-15302935
 ] 

ASF GitHub Bot commented on QUARKS-188:
---------------------------------------

GitHub user dlaboss opened a pull request:

    https://github.com/apache/incubator-quarks/pull/124

    [QUARKS-188] Console don't traverse (non-injected) metric ops

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlaboss/incubator-quarks 
quarks-188-consoleMetricPropagation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit ea885f5ee77c3d50eb67e6d34aa51463f9de5a4b
Author: Dale LaBossiere <[email protected]>
Date:   2016-05-26T21:01:55Z

    [QUARKS-188] Console don't traverse (non-injected) metric ops

----


> Console metric propagation shouldn't traverse non-injected metric ops
> ---------------------------------------------------------------------
>
>                 Key: QUARKS-188
>                 URL: https://issues.apache.org/jira/browse/QUARKS-188
>             Project: Quarks
>          Issue Type: Task
>          Components: Console
>            Reporter: Dale LaBossiere
>            Assignee: Dale LaBossiere
>            Priority: Minor
>
> QUARKS-22 / PR-116 added "metric propagation" so edge segments get proper 
> width rendering and edge hovers report metrics across injected ops.
> The traversal code was including (non-injected) CounterOp and RateMetric 
> oplets which is undesirable since each such oplet is included in the 
> retrieved "counter metrics" hence each already ended up setting its adjecent 
> edges' metric value.  Hence traversing them too is unnecessary / extra work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to