[
https://issues.apache.org/jira/browse/QUARKS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313101#comment-15313101
]
ASF GitHub Bot commented on QUARKS-120:
---------------------------------------
GitHub user dlaboss opened a pull request:
https://github.com/apache/incubator-quarks/pull/127
[WIP] [QUARKS-120] fix broken graph for "middle peek fanout" case
- fix the case
- this is an incremental ~minimal change fix. It feels a bit hacky and
doesn't address some other concerns with the EtiaoConnector.
- enhance tests to include the case
- clarify Connector.isConnect()'s existing semantics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlaboss/incubator-quarks
quarks-120-broken-graph
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
----
commit 3c36095ce67a665a8f4ffd41f661b3326a072881
Author: Dale LaBossiere <[email protected]>
Date: 2016-06-02T21:26:27Z
[QUARKS-120] fix broken graph for "middle peek fanout" case
- fix the case
- this is an incremental ~minimal change fix. It feels a bit hacky and
doesn't address some other concerns with the EtiaoConnector.
- enhance tests to include the case
- clarify Connector.isConnect()'s existing semantics
----
> bad graph generation with certain API / oplet sequence
> ------------------------------------------------------
>
> Key: QUARKS-120
> URL: https://issues.apache.org/jira/browse/QUARKS-120
> Project: Quarks
> Issue Type: Bug
> Components: Console, Runtime
> Reporter: May Wone
> Assignee: Dale LaBossiere
> Priority: Minor
> Attachments: CounterAsSourceComplexTupleType.doc, CounterSource.doc
>
>
> In the graph for TopologyTestBasic, a counter oplet appears to be a source
> (i.e. there's no other oplet pointing to the counter oplet). This looks odd
> to me - is this expected?
> Note this source uses a complex tuple type, i.e. a tuple is a Java object.
> The oplets 130, 77, 76 look odd - is this graph starting at oplet 130
> expected?
> 130 is a counter oplet that looks like a source.
> 77 is a fanout¬ (see View all oplet properties table below).
> There is tag "mcs1".
> See attachment for screen shots.
> {code}
> //**************************************************************
> //Source 2 using complex tuple type
> //**************************************************************
> Random r2 = new Random();
> TStream<MyClass1> mc1 = t.poll(
> () -> new MyClass1(Double.toString(r2.nextGaussian()),
>
> Double.toString(r2.nextGaussian()),r1.nextGaussian()
> ),100, TimeUnit.MILLISECONDS).tag("mc1");
> mc1.peek(g -> System.out.print(g.toString()));
> mc1.modify(tuple -> new MyClass1(tuple.getS1() + "a1 b1 c1 d1 ",
> tuple.getS2() +" e1 f1 g1 h1 ", tuple.getD1() +1) );
> mc1.peek(tuple -> System.out.println("MyClass1: " +
> tuple.toString()));
> mc1.flatMap(tuple -> Arrays.asList(tuple.toString().split(" ")));
> //An asString
> TStream<String> mcs1 = mc1.asString().tag("mcs1");
> mcs1.peek(tuple -> System.out.println(" mcs1_source2: " +
> tuple.toString()));
> List<TStream<String>> splits2 = mcs1.split(2, tuple -> {
> switch (tuple.toString().charAt(0)) {
> case '-': //negative numbers
> return 0;
> default: //everything else
> return 1;
> }
> });
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
