GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/7
Bug fixed in SimpleScalarSeparateChainingHashTable::isFull()
- Earlier check for isFull() was that whether there is at least one empty
bucket available for insertion.
- Now isFull() can check if there is enough space for adding specified
number of buckets.
- To reproduce the bug behind this fix: Run TPC-H Q2 on SF100 dataset after
running the \analyze command. The optimizer allocates smaller than
necessary space for one of the hash joins. The resize() is triggered
but never gets executed because of the restrictive isFull() condition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
simple-scalar-isfull-bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 69c65518ff603081e724be581badffc7efeabead
Author: Harshad Deshmukh <[email protected]>
Date: 2016-06-03T20:28:52Z
Bug fixed in isFull() function.
- Earlier check for isFull() was that whether there is at least one
empty bucket available for insertion.
- Now isFull() can check if there is enough space adding specified
number of buckets.
- To reproduce the bug behind this fix: Run TPC-H Q2 on SF100 dataset after
running the \analyze command. The optimizer allocates smaller than
necessary space for one of the hash joins. The resize() is triggered
but never gets executed because of the restrictive isFull() condition.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
