Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/8
Hi @pateljm @zuyu I beg to differ on this point. In most places I tried to
conform to the Google C++ style guide which we use as a reference. The relevant
section in the style guide can be found here:
https://google.github.io/styleguide/cppguide.html#Function_Parameter_Ordering
It says that parameters should be ordered as inputs first (const
references, const ints etc) followed by outputs (roughly speaking - pointers).
Few places where I couldn't follow this convention was where already the
convention wasn't followed.
I think this issue boils down to personal style preferences that are not
present in the style guide. Such comments are difficult to argue and enforce
unlike some of the performance or correctness related comments which can be
fairly objective. Going by such a rule on parameter ordering, I am sure there
will be a lot of other places in the code which will need a refactoring. It
will be better if either we modify the style guide so that everybody is on the
same page or alternatively not enforce such a style preference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
