Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/10#discussion_r66313789
--- Diff: query_optimizer/tests/ExecutionHeuristics_unittest.cpp ---
@@ -75,12 +75,12 @@ class ExecutionHeuristicsTest : public ::testing::Test {
std::vector<attribute_id> build_attribute_ids;
build_attribute_ids.push_back(build_attribute_id);
QueryPlan::DAGNodeIndex build_operator_index =
- query_plan->addRelationalOperator(new
BuildHashOperator(*build_relation,
+ query_plan->addRelationalOperator(new BuildHashOperator(0, /*
dummy query ID */
--- End diff --
This suggestion will require some work as there are a number of unit tests
which need this change. The dummy query ID flag is informative as of now. We
can come back to it later, if that's fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
