Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/19#discussion_r66457753
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -274,439 +116,293 @@ TextScanWorkOrder::TextScanWorkOrder(const
std::size_t query_id,
void TextScanWorkOrder::execute() {
const CatalogRelationSchema &relation =
output_destination_->getRelation();
+ std::vector<Tuple> tuples;
- string current_row_string;
- if (is_file_) {
- FILE *file = std::fopen(filename_.c_str(), "r");
- if (file == nullptr) {
- throw TextScanReadError(filename_);
- }
+ constexpr std::size_t kSmallBufferSize = 0x4000;
--- End diff --
Again, I was curious how we came up with this number. Does a different
value would change the loading performance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
