Github user pateljm commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66715752
--- Diff: storage/InsertDestination.cpp ---
@@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const
CatalogRelationSchema &relation,
const StorageBlockLayout *layout,
StorageManager *storage_manager,
const std::size_t relational_op_index,
+ const std::size_t query_id,
--- End diff --
Ok -- how about in the sprit of moving forward, we close this discussion
and PR if the reordering is the only issue. We can work on the reordering in a
separate PR.
@zuyu -- can you confirm that the reodering is the only issue that is left
on the table from your perspective? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
