Github user navsan commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66853219
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break;
}
+#ifdef QUICKSTEP_ENABLE_GOOGLE_PROFILER
+ // Profile only if profile_file_name flag is set
+ if (!started_profiling &&
!quickstep::FLAGS_profile_file_name.empty()) {
--- End diff --
Added the explanation in the the QuickstepCli.cpp file. Are we good to
merge?
Thanks @zuyu, @hbdeshmukh for the thorough comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
