Github user shixuan-fan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/35#discussion_r67520588
  
    --- Diff: parser/SqlParser.ypp ---
    @@ -1332,6 +1369,83 @@ opt_limit_clause:
         }
       }
     
    +opt_window_clause:
    +  {
    +    $$ = nullptr;
    +  }
    +  | window_declaration_list
    +
    +window_declaration_list:
    +  window_declaration {
    +    $$ = new quickstep::PtrList<quickstep::ParseWindow>();
    +    $$->push_back($1);
    +  }
    +  | window_declaration_list window_declaration {
    +    $$ = $1;
    +    $$->push_back($2);
    +  }
    +
    +window_declaration:
    --- End diff --
    
    @zuyu Since window_declaration is a part of window_declaration_list,I put 
it this way in order to maintain the hierarchy. If alphabet order has higher 
precedence then I will change them. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to