Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68327923
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -209,6 +227,26 @@ struct Resolver::QueryAggregationInfo {
std::vector<E::AliasPtr> aggregate_expressions;
};
+struct Resolver::WindowPlan {
+ explicit WindowPlan(E::WindowInfo window_info_in,
--- End diff --
No need for `explicit`, and we may want to add a reference to
`window_info_in`, or use a rvalue instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
