Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/46#discussion_r68813619
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1032,7 +1032,7 @@ L::LogicalPtr Resolver::resolveSelect(
L::LogicalPtr sorted_logical_plan = resolveSortInWindow(logical_plan,
resolved_window);
- WindowPlan window_plan(resolved_window, sorted_logical_plan);
+ WindowPlan window_plan(std::move(resolved_window),
sorted_logical_plan);
sorted_window_map.emplace(window.name()->value(), window_plan);
--- End diff --
Please use `move` in `sorted_window_map` as well:
`sorted_window_map.emplace(window.name()->value(), std::move(window_plan));`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
