Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/52#discussion_r70070769
--- Diff: query_execution/CMakeLists.txt ---
@@ -82,12 +86,8 @@ target_link_libraries(quickstep_queryexecution_Foreman
quickstep_threading_ThreadUtil
quickstep_utility_EqualsAnyConstant
quickstep_utility_Macros
- tmb)
-target_link_libraries(quickstep_queryexecution_ForemanLite
- glog
- quickstep_threading_Thread
- quickstep_utility_Macros
- tmb)
+ tmb
+ ${GFLAGS_LIB_NAME})
--- End diff --
``${GFLAGS_LIB_NAME}`` should appear before ``glog`` in alphabetical order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---