Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/54#discussion_r70500461
--- Diff: query_execution/QueryManagerBase.hpp ---
@@ -255,69 +212,75 @@ class QueryManager {
* otherwise.
**/
inline bool checkOperatorExecutionOver(const dag_node_index index) const
{
- if (checkRebuildRequired(index)) {
- return (checkNormalExecutionOver(index) && checkRebuildOver(index));
- } else {
- return checkNormalExecutionOver(index);
- }
+ return this->checkNormalExecutionOver(index) &&
+ (!checkRebuildRequired(index) || this->checkRebuildOver(index));
--- End diff --
I would say that the refactor has the following logical flow: first check
the normal execution of work orders, and then the rebuild.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
