Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/64#discussion_r72500396
  
    --- Diff: query_execution/QueryExecutionTypedefs.hpp ---
    @@ -73,9 +73,17 @@ enum QueryExecutionMessageType : message_type_id {
       kPoisonMessage,  // From the main thread to Foreman and Workers.
     
     #ifdef QUICKSTEP_DISTRIBUTED
    +  kShiftbossRegistrationMessage,  // From Shiftboss to Foreman.
    +  kShiftbossRegistrationResponseMessage,  // From Foreman to Shiftboss.
    +  kQueryInitiateMessage,  // From Foreman to Shiftboss.
    +  kQueryInitiateResponseMessage,  // From Shiftboss to Foreman.
    +
       kInitiateRebuildMessage,  // From Foreman to Shiftboss.
       kInitiateRebuildResponseMessage,  // From Shiftboss to Foreman.
     
    +  kQueryResultRelationMessage,  // From Foreman to Shiftboss.
    +  kQueryResultRelationResponseMessage,  // From Shiftboss to Foreman.
    --- End diff --
    
    We will add a new unit test for the distributed query execution engine.
    
    And I have tested it end-to-end in [a old 
repo](https://github.com/pivotalsoftware/quickstep/pull/117), w/o concurrent 
query support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to