Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/96#discussion_r75956345
--- Diff: relational_operators/WorkOrderFactory.cpp ---
@@ -533,11 +530,13 @@ bool WorkOrderFactory::ProtoIsValid(const
serialization::WorkOrder &proto,
return false;
}
+ const CatalogRelationSchema &build_relation =
catalog_database.getRelationSchemaById(build_relation_id);
const CatalogRelationSchema &probe_relation =
catalog_database.getRelationSchemaById(probe_relation_id);
for (int i = 0; i <
proto.ExtensionSize(serialization::HashJoinWorkOrder::join_key_attributes);
++i) {
const attribute_id attr_id =
proto.GetExtension(serialization::HashJoinWorkOrder::join_key_attributes, i);
- if (!probe_relation.hasAttributeWithId(attr_id)) {
+ if (!build_relation.hasAttributeWithId(attr_id) ||
--- End diff --
Note that I had removed the check for `build_relation`, as the `attr_id` in
`probe_relation` may be different to that in `build_relation`, although both
refer to the same `CatalogAttribute`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
