GitHub user cramja opened a pull request:

    Refactor bulk insert for SplitRowStore

    This code refactors out multiple calls to the catalog in tight insert loops.
    We see a 2x improvement on large inserts.

You can merge this pull request into a Git repository by running:

    $ git pull refactor_bulk_ins

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
commit 29ebdae0e6218e9b8a3e3df2b056c6f62d598529
Author: cramja <>
Date:   2016-09-16T21:35:19Z

    BulkInsert optimization for SplitRowStore
    This change adds a struct which holds the calculations for insert
    information for tuples coming from a value accessor and being inserted
    into a splitrowstore tuple block. This greatly speeds up highly
    unselective queries.

commit 57bd3e893b564327d7204039b479d04fa385738e
Author: cramja <>
Date:   2016-09-16T23:19:16Z

    Adds insert optimization to bulkInsertWithRemappedAttributes
    Similar (copy+paste with one addition) to the last change to the

commit 47a1a4b62a12a3e74f6f687d75180f935e2b965c
Author: cramja <>
Date:   2016-09-20T01:22:41Z

    Removes duplicate code in bulkInsert
    This refactor is meant to remove code complexity via removing duplicate
    code. Prefer cleaner/more maintainable code over a slightly faster 


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to