Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/111#discussion_r84497021
--- Diff: query_execution/PolicyEnforcerBase.hpp ---
@@ -163,6 +174,8 @@ class PolicyEnforcerBase {
// Key = query ID, value = QueryManagerBase* for the key query.
std::unordered_map<std::size_t, std::unique_ptr<QueryManagerBase>>
admitted_queries_;
+ std::unordered_set<std::size_t> removed_query_ids_;
--- End diff --
Thanks @zuyu
Apologies for being slow to review this PR. Can you please add the TODO
about garbage collection on ``removed_query_ids_``, and I will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
