Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/160#discussion_r96450595
--- Diff: query_optimizer/physical/CreateTable.hpp ---
@@ -107,8 +115,9 @@ class CreateTable : public Physical {
static CreateTablePtr Create(
const std::string &relation_name,
const std::vector<expressions::AttributeReferencePtr> &attributes,
- const std::shared_ptr<const StorageBlockLayoutDescription>
&block_properties) {
- return CreateTablePtr(new CreateTable(relation_name, attributes,
block_properties));
+ const std::shared_ptr<const StorageBlockLayoutDescription>
&block_properties,
+ const std::shared_ptr<const serialization::PartitionSchemeHeader>
&partition_scheme_header_proto) {
+ return CreateTablePtr(new CreateTable(relation_name, attributes,
block_properties, partition_scheme_header_proto));
--- End diff --
Add a comment for `partition_scheme_header_proto` in method header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
