Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/162#discussion_r96884965
  
    --- Diff: storage/InsertDestination.cpp ---
    @@ -789,7 +789,7 @@ void 
PartitionAwareInsertDestination::returnBlockInPartition(MutableBlockReferen
                                                            << "invalidated one 
or more IndexSubBlocks.");
       }
       // Note that the block will only be sent if it's full (true).
    -  sendBlockFilledMessage(block->getID());
    +  sendBlockFilledMessage(block->getID(), part_id);
    --- End diff --
    
    In BlockPool implementation of InsertDestination, there's no information 
about partition ID. If that class sends a block filled message, which further 
gets passed to a consumer relational operator, do we use 0 as the partition ID? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to