Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99884619
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -1495,9 +1607,28 @@ void ExecutionGenerator::convertAggregate(
}
if (!group_by_types.empty()) {
- // Right now, only SeparateChaining is supported.
- aggr_state_proto->set_hash_table_impl_type(
- serialization::HashTableImplType::SEPARATE_CHAINING);
+ const std::size_t estimated_num_groups =
+
cost_model_for_aggregation_->estimateNumGroupsForAggregate(physical_plan);
+
+ std::size_t max_num_groups;
+ const bool can_use_collision_free_aggregation =
+ canUseCollisionFreeAggregation(physical_plan,
+ estimated_num_groups,
+ &max_num_groups);
+
+ if (can_use_collision_free_aggregation) {
--- End diff --
Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
