Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/184#discussion_r100128102
  
    --- Diff: BUILDING.md ---
    @@ -1,60 +1,71 @@
    -Quickstep Build Guide
    -=====================
    +# Quickstep Build Guide
     
    +**Contents**
    +* [Basic Instructions](#basic-instructions)
    +  * [Prerequisites](#prerequisites)
    +  * [Building](#building)
    +  * [Running Quickstep](#running-quickstep)
    +  * [Running Tests](#running-tests)
    +  * [Configuring with CMake](#configuring-with-cmake)
    +* [Advanced Configuration](#advanced-configuration)
    +* [Appendix](#appendix)
    +  * [Building on Windows](#building-on-windows)
    +  * [Building in Vagrant](#building-in-vagrant)
     
    -What You Will Need
    -------------------
     
    -To build quickstep, you will need a C++ compiler that supports the C++14
    -standard (GCC 4.9 or Clang 3.4 or higher are known to work), and CMake. If 
you
    -have GNU Bison and Flex as well, they will be used to build the parser and
    -lexer sources (otherwise, preprocessed sources made with Bison and Flex 
will be
    -used).
    +**Short Version**
     
    -### Vagrant
    +```sh
    +cd third_party
    +./download_and_patch_prerequisites.sh
    +cd ../build
    +cmake ..
    +make -j4 quickstep_cli_shell
    --- End diff --
    
    I'd suggest to remove `-j4` here, as it does not apply to everyone, and we 
have mentioned the parallel build jobs later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to