Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/181#discussion_r104571182
  
    --- Diff: query_optimizer/tests/execution_generator/Partition.test ---
    @@ -15,19 +15,35 @@
     # specific language governing permissions and limitations
     # under the License.
     
    -CREATE TABLE foo (id INT NULL,
    -                  name CHAR(20))
    +CREATE TABLE dim (id INT NULL,
    --- End diff --
    
    Optional, but it may be easier to read if the relation is named as 
``dim_4_hash_partitions``. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to