Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104720132
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -679,13 +688,72 @@ void ExecutionGenerator::convertFilterJoin(const
P::FilterJoinPtr &physical_plan
std::piecewise_construct,
std::forward_as_tuple(physical_plan),
std::forward_as_tuple(probe_relation_info->producer_operator_index,
- probe_relation_info->relation));
+ probe_relation_info->relation,
+
probe_relation_info->output_destination_index));
DCHECK(lip_filter_generator_ != nullptr);
lip_filter_generator_->addFilterJoinInfo(physical_plan,
build_filter_operator_index);
}
+namespace {
+
+bool areSamePartitionSchemeHeaders(const PartitionSchemeHeader
&lhs_partition_header,
--- End diff --
I had a discussion with @jianqiao on this issue. He thinks that the
partitioning related code should be moved to different functions at least. That
way the overall code is easier to read and is also extensible. He's fine with
the anonymous namespace arrangement.
An example is all the new code in ``convertHashJoin`` can be moved to
separate function(s) and then called from ``convertHashJoin``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
